Conditionally removing fields from introspection #1004
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still work in progress breaks if FieldContext.Parent.Result is not an *introspection.Type |
vvakame
reviewed
Feb 6, 2020
| if c.AllowInputValueFunc == nil { | ||
| return | ||
| } | ||
| t := fc.Parent.Result.(*introspection.Type) |
There was a problem hiding this comment.
intropection.Type, intropection.Directive and introspection.Field will be coming.
https://spec.graphql.org/June2018/#sec-Schema-Introspection __InputValue
There was a problem hiding this comment.
I was thinking to change it to something like
type Introspection struct {
Auth IntrospectionAuth
}
type IntrospectionAuth interface {
AllowEnumValues(ctx context.Context, enumValues []introspection.EnumValue) ([]introspection.EnumValue, error)
AllowFields(ctx context.Context, fields []introspection.Field) ([]introspection.Field, error)
AllowInputValues(ctx context.Context, inputValues []introspection.InputValue) ([]introspection.InputValue, error)
}
and the allow func would be something like:
AllowFieldsFunc: func(ctx context.Context, fields []introspection.Field) ([]introspection.Field, error) {
fc := graphql.GetFieldContext(ctx)
newFields := make([]introspection.Field, 0, len(fields))
if t, ok := fc.Parent.Result.(*introspection.Type); ok && *t.Name() == "TestType1" {
for _, field := range fields {
if field.Name == "TestField1" {
continue
}
newFields = append(newFields, field)
}
return newFields, nil
}
return fields, nil
},
This way the allow func is more verbose, but is called just one time and there is no need to have one function for each of intropection.Type, intropection.Directive and introspection.Field.
What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #380
How to use
Use introspection plugin with
AllowFieldFuncandAllowInputValueFunc.How it works
Introspectionextension now implementsFieldInterceptor.When
InterceptFieldis called checks if the result returned bynext()is[]introspection.Fieldor[]introspection.InputValue.If any of the two conditions is true proceeds to filter field using the correct
AllowFuncspecified when creating the extension.I have: